[SPARK-54474][PYTHON] Discard the XML report on tests that are supposed to fail #53187
+28
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ueshin I think you added this a few months ago and I happen to know why it was added :) |
ueshin
approved these changes
Nov 23, 2025
HyukjinKwon
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We do not keep the XML reports from the tests that are supposed to fail anymore.
Why are the changes needed?
It will confuse XML report consumers. These are tests that are supposed to fail - we are testing if they return the expected return code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested that no XML report is generated and the test itself still passes.
Was this patch authored or co-authored using generative AI tooling?
No